[webkit-reviews] review granted: [Bug 220972] Color Gamut for VP8 and VP9 seems wrong : [Attachment 426812] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Jean-Yves Avenard [:jya]
<jya at apple.com>'s request for review:
Bug 220972: Color Gamut for VP8 and VP9 seems wrong
https://bugs.webkit.org/show_bug.cgi?id=220972

Attachment 426812: Patch

https://bugs.webkit.org/attachment.cgi?id=426812&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 426812
  --> https://bugs.webkit.org/attachment.cgi?id=426812
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426812&action=review

> LayoutTests/webrtc/video-vp8-videorange.html:43
> +	   testRunner.setUserMediaPermission(true);

Not needed.

> LayoutTests/webrtc/video-vp8-videorange.html:45
> +    return new Promise((resolve, reject) => {

You could do: promise_test(async (test) => {
And then use await:
const remoteStream = await new Promise(...)

> LayoutTests/webrtc/video-vp8-videorange.html:81
> +}, "Ensuring connection state is connected");

Not sure this is actually needed, video.play() will resolve once it gets a
remove video frame which means connection is ok.

> LayoutTests/webrtc/video-vp8-videorange.html:84
> +    return checkVideoBlack(false, canvas2, video).then(() => {

async (test) and await checkVideoBlack(...); would make it a bit nicer.

> LayoutTests/webrtc/video-vp8-videorange.html:88
> +	   assert_equals([ pixelData[0], pixelData[1], pixelData[2] ].join(),
[0, 0, 0].join());

Are we sure they will always be 0,0,0 given we do compression?

> LayoutTests/webrtc/video-vp8-videorange.html:91
> +	   assert_equals([ pixelData[0], pixelData[1], pixelData[2] ].join(),
[255, 255, 255].join());

Ditto here.