[webkit-reviews] review granted: [Bug 177934] [SOUP] Add support for preconnect : [Attachment 426541] Patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 177934: [SOUP] Add support for preconnect
https://bugs.webkit.org/show_bug.cgi?id=177934

Attachment 426541: Patch

https://bugs.webkit.org/attachment.cgi?id=426541&action=review




--- Comment #9 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 426541
  --> https://bugs.webkit.org/attachment.cgi?id=426541
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426541&action=review

> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:256
> +#if !USE(SOUP2)

What about && ENABLE(SERVER_PRECONNECT) ?

> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:463
> +#if !USE(SOUP2)

Ditto

> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:478
> +}

I'd suggest using makeScopeExit for the clearRequest() call. However I am not
sure whether the RefPtr::deref is executed after it so we can leave it as it
just in case.