[webkit-reviews] review granted: [Bug 222795] [LibWebRTC][WPE][GTK] Enable vp9 and NO_MAIN_THREAD_WRAPPING : [Attachment 426682] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 22 01:37:54 PDT 2021


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 222795: [LibWebRTC][WPE][GTK] Enable vp9 and NO_MAIN_THREAD_WRAPPING
https://bugs.webkit.org/show_bug.cgi?id=222795

Attachment 426682: Patch

https://bugs.webkit.org/attachment.cgi?id=426682&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 426682
  --> https://bugs.webkit.org/attachment.cgi?id=426682
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426682&action=review

>
Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
159
> +	   gst_bin_add_many(GST_BIN_CAST(m_pipeline.get()), m_src.get(),
videoconvert, videoscale, m_capsFilter.get(), m_encoder.get(), m_sink.get(),
nullptr);
> +	   if (!gst_element_link_many(m_src.get(), videoconvert, videoscale,
m_capsFilter.get(), m_encoder.get(), m_sink.get(), nullptr)) {
> +	      
GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN_CAST(m_pipeline.get()),
GST_DEBUG_GRAPH_SHOW_VERBOSE, "webkit-webrtc-encoder.error");

I think we should at least warn here as well.


More information about the webkit-reviews mailing list