[webkit-reviews] review granted: [Bug 224578] [JSC] DFG / FTL should inline switch_string : [Attachment 426776] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 224578: [JSC] DFG / FTL should inline switch_string
https://bugs.webkit.org/show_bug.cgi?id=224578

Attachment 426776: Patch

https://bugs.webkit.org/attachment.cgi?id=426776&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 426776
  --> https://bugs.webkit.org/attachment.cgi?id=426776
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426776&action=review

r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   This allows DFG / FTL to inline CodeBlock which includes
op_switch_string. We were not able

I suggest "were previously not able".

> Source/JavaScriptCore/ChangeLog:13
> +	   1. We handle StringJumpTable / UnlinkedStringJumpTable in the same
way to SimpleJumpTable / UnlinkedSimpleJumpTable.

/same way to/same way as/.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:16748
>	   LValue branchOffset = vmCall(

Can you rename this node to `branchIndex` to match
`operationSwitchStringAndGetIndex`?