[webkit-reviews] review granted: [Bug 224914] [RenderTreeBuilder] Multi-column spanners are not part of the enclosing multi-column renderer's subtree : [Attachment 426769] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 224914: [RenderTreeBuilder] Multi-column spanners are not part of the
enclosing multi-column renderer's subtree
https://bugs.webkit.org/show_bug.cgi?id=224914

Attachment 426769: Patch

https://bugs.webkit.org/attachment.cgi?id=426769&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 426769
  --> https://bugs.webkit.org/attachment.cgi?id=426769
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426769&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:749
> +		       // This child is a spanner so it is not in the subtree
of the multicolumn renderer (parented directly under the block flow). 

The parenthetical adds confusion. Write it as a new sentence.