[webkit-reviews] review granted: [Bug 224891] [GPUP] Refactor SourceBuffer::enqueuedSamplesForTrackID() for testing purposes : [Attachment 426739] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 224891: [GPUP] Refactor SourceBuffer::enqueuedSamplesForTrackID() for
testing purposes
https://bugs.webkit.org/show_bug.cgi?id=224891

Attachment 426739: Patch

https://bugs.webkit.org/attachment.cgi?id=426739&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 426739
  --> https://bugs.webkit.org/attachment.cgi?id=426739
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426739&action=review

>
LayoutTests/media/media-source/media-source-append-presentation-durations.html:
56
> +	   enqueuedSamples = await
internals.enqueuedSamplesForTrackID(sourceBuffer, 1);

Nit: `const enqueuedSamples = ...`

> LayoutTests/media/media-source/media-source-erase-after-last-append.html:50
> +	       enqueuedSamples = await
internals.enqueuedSamplesForTrackID(sourceBuffer, 1);

Ditto

>
LayoutTests/media/media-source/media-source-first-append-not-starting-at-zero.h
tml:45
> +	   enqueuedSamples = await
internals.enqueuedSamplesForTrackID(sourceBuffer, 1);

Nit: `let enqueuedSamples = ...`

> LayoutTests/media/media-source/media-source-remove-b-frame.html:45
> +	   enqueuedSamples = await
internals.enqueuedSamplesForTrackID(sourceBuffer, 1);

Ditto