[webkit-reviews] review granted: [Bug 224750] Add memory allocation checks in more realtime audio capture/rendering places : [Attachment 426679] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 21 10:00:47 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 224750: Add memory allocation checks in more realtime audio
capture/rendering places
https://bugs.webkit.org/show_bug.cgi?id=224750

Attachment 426679: Patch

https://bugs.webkit.org/attachment.cgi?id=426679&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 426679
  --> https://bugs.webkit.org/attachment.cgi?id=426679
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426679&action=review

> Source/WebCore/platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.h:60
> +    static constexpr size_t ChunksReceivedDelta = 200; // 200 chunks of 10ms
= 2s.

I had to look at the source to understand what this constant is for, maybe
"LogAfterChunksRecieved" or "ChunksRecievedLogCount"?


More information about the webkit-reviews mailing list