[webkit-reviews] review granted: [Bug 224786] [CMake] Add OpenGLES2 targets : [Attachment 426587] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 224786: [CMake] Add OpenGLES2 targets
https://bugs.webkit.org/show_bug.cgi?id=224786

Attachment 426587: Patch

https://bugs.webkit.org/attachment.cgi?id=426587&action=review




--- Comment #19 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 426587
  --> https://bugs.webkit.org/attachment.cgi?id=426587
Patch

Patch LGTM as well. Please remember to remove the X11 include before landing :)


View in context: https://bugs.webkit.org/attachment.cgi?id=426587&action=review

>> Source/cmake/FindOpenGLES2.cmake:88
>> +endif ()
> 
> LGTM, but we would need a graphics developer to say whether this really makes
sense.

At least the switcheroo checking for headers is fine. The specs indicate which
headers must be available at different API levels, and as GLESv2 is the minimum
we support, making it fallback makes sense.