[webkit-reviews] review granted: [Bug 224773] Support scrolling to a selected AppHighlight : [Attachment 426647] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 20 22:21:47 PDT 2021


Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 224773: Support scrolling to a selected AppHighlight
https://bugs.webkit.org/show_bug.cgi?id=224773

Attachment 426647: Patch

https://bugs.webkit.org/attachment.cgi?id=426647&action=review




--- Comment #18 from Tim Horton <thorton at apple.com> ---
Comment on attachment 426647
  --> https://bugs.webkit.org/attachment.cgi?id=426647
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426647&action=review

> Source/WebCore/Modules/highlight/AppHighlightStorage.h:66
> +    bool attemptToRestoreHighlightAndScroll(AppHighlightRangeData&,
ScrollToHighlight);

still missing this newline


More information about the webkit-reviews mailing list