[webkit-reviews] review granted: [Bug 224773] Support scrolling to a selected AppHighlight : [Attachment 426640] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 224773: Support scrolling to a selected AppHighlight
https://bugs.webkit.org/show_bug.cgi?id=224773

Attachment 426640: Patch

https://bugs.webkit.org/attachment.cgi?id=426640&action=review




--- Comment #16 from Tim Horton <thorton at apple.com> ---
Comment on attachment 426640
  --> https://bugs.webkit.org/attachment.cgi?id=426640
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426640&action=review

> Source/WebCore/Modules/highlight/AppHighlightStorage.h:66
> +    bool attemptToRestoreHighlightAndScroll(AppHighlightRangeData&,
ScrollToHighlight);

Newline below here, before the members.

> Source/WebCore/page/Page.cpp:1623
> -#if ENABLE(APP_HIGHLIGHT)
> +#if ENABLE(APP_HIGHLIGHTS)

Should make sure that there's a test that covers this code (maybe in another
patch)

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2157
> +static void convertAndAddHighlight(Vector<Ref<WebKit::SharedMemory>>
&buffers, NSData* highlight)

star's on the wrong side