[webkit-reviews] review granted: [Bug 224840] Crash due to VectorBuffer pre-allocation failure : [Attachment 426614] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 20 17:42:25 PDT 2021
Sam Weinig <sam at webkit.org> has granted Ian Gilbert <iang at apple.com>'s request
for review:
Bug 224840: Crash due to VectorBuffer pre-allocation failure
https://bugs.webkit.org/show_bug.cgi?id=224840
Attachment 426614: Patch
https://bugs.webkit.org/attachment.cgi?id=426614&action=review
--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 426614
--> https://bugs.webkit.org/attachment.cgi?id=426614
Patch
I don't quite know how to review the test, but the change looks good.
I think there might be a similar issue in:
ArgumentCoder<WebCore::CDMInstanceSession::KeyStatusVector>::decode(...)
which does a `keyStatuses.reserveInitialCapacity(dataSize);` from a decoded
size.
More information about the webkit-reviews
mailing list