[webkit-reviews] review granted: [Bug 224841] v2: Web Inspector: exempt API::SharedJSContext from remote inspection and automatic inspection : [Attachment 426611] Patch v1.0

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted BJ Burg <bburg at apple.com>'s
request for review:
Bug 224841: v2: Web Inspector: exempt API::SharedJSContext from remote
inspection and automatic inspection
https://bugs.webkit.org/show_bug.cgi?id=224841

Attachment 426611: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=426611&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 426611
  --> https://bugs.webkit.org/attachment.cgi?id=426611
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=426611&action=review

r=me

Out of curiosity, does this prevent inspection forever?  Or does it just
prevent auto-attach/auto-pause?  Would be nice to still be able to inspect this
later on if possible :)

> Source/WebKit/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:52
>	       [m_context _setRemoteInspectionEnabled:NO];

I think we can remove this since it's only set `if
(JSRemoteInspectorGetInspectionEnabledByDefault())`.