[webkit-reviews] review granted: [Bug 224452] Lots of spurious -Wnonnull warnings with GCC 11 : [Attachment 426605] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 224452: Lots of spurious -Wnonnull warnings with GCC 11
https://bugs.webkit.org/show_bug.cgi?id=224452

Attachment 426605: Patch

https://bugs.webkit.org/attachment.cgi?id=426605&action=review




--- Comment #33 from Darin Adler <darin at apple.com> ---
Comment on attachment 426605
  --> https://bugs.webkit.org/attachment.cgi?id=426605
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426605&action=review

> Source/WTF/wtf/Compiler.h:507
> +#define IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_BEGIN
IGNORE_GCC_WARNINGS_BEGIN("nonnull")
> +#define IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_END IGNORE_GCC_WARNINGS_END

Maybe there should be a comment here pointing at the GCC compiler bug?

> Source/WebCore/dom/Node.h:797
> +// https://bugs.webkit.org/show_bug.cgi?id=224452#c21

Do we really need these comments? Maybe a single comment at the definition of
IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_BEGIN is enough.

> Source/WebKit/WebProcess/Plugins/PluginView.cpp:149
> +// https://bugs.webkit.org/show_bug.cgi?id=224452#c24
> +IGNORE_NULL_CHECK_WARNINGS_BEGIN

Ditto.

Shouldn’t this be using IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_BEGIN? Or is
this different?