[webkit-reviews] review granted: [Bug 224763] Separated models don't get opacity set on them at all : [Attachment 426564] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 224763: Separated models don't get opacity set on them at all
https://bugs.webkit.org/show_bug.cgi?id=224763

Attachment 426564: Patch

https://bugs.webkit.org/attachment.cgi?id=426564&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 426564
  --> https://bugs.webkit.org/attachment.cgi?id=426564
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426564&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3946
> +    if (&layer == m_contentsLayer.get()) {

I love this.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3987
> +	   if (flags.contains(PlatformLayerTreeAsTextFlags::IncludeOpacity))

It is probably overkill to add a flag for opacity, just only dump it if it's
non-1? But this is fine too.

> LayoutTests/model-element/model-element-graphics-layers.html:22
> +	   model.remove();

subtle and hilarious. someday we should really debug this.