[webkit-reviews] review granted: [Bug 224602] MacCatalyst ANGLE is linked with @loader_path/../../../libANGLE-shared.dylib : [Attachment 426562] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 20 14:09:30 PDT 2021


Alexey Proskuryakov <ap at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 224602: MacCatalyst ANGLE is linked with
@loader_path/../../../libANGLE-shared.dylib
https://bugs.webkit.org/show_bug.cgi?id=224602

Attachment 426562: Patch

https://bugs.webkit.org/attachment.cgi?id=426562&action=review




--- Comment #9 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 426562
  --> https://bugs.webkit.org/attachment.cgi?id=426562
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426562&action=review

> Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:26
> +DYLIB_INSTALL_NAME_BASE_USE_ALTERNATE_FRAMEWORKS_DIR_YES = @(INSTALL_PATH);

Looking at other projects, and even at the below line, we are using
DYLIB_INSTALL_NAME_BASE for this case, not INSTALL_PATH.

There is probably no difference in practice, but let's use the same solution as
elsewhere.


More information about the webkit-reviews mailing list