[webkit-reviews] review granted: [Bug 222594] Add basic (non-momentum) wheel event handling for scroll snap : [Attachment 426538] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 222594: Add basic (non-momentum) wheel event handling for scroll snap
https://bugs.webkit.org/show_bug.cgi?id=222594

Attachment 426538: Patch

https://bugs.webkit.org/attachment.cgi?id=426538&action=review




--- Comment #19 from Darin Adler <darin at apple.com> ---
Comment on attachment 426538
  --> https://bugs.webkit.org/attachment.cgi?id=426538
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426538&action=review

Looks fine.

> Source/WebCore/platform/ScrollAnimator.cpp:182
>  #if PLATFORM(MAC)
> -bool ScrollAnimator::processWheelEventForScrollSnap(const
PlatformWheelEvent& wheelEvent)
> -{
> -    return m_scrollController.processWheelEventForScrollSnap(wheelEvent);
> -}
>  #endif

Since we’re deleting this code, please delete the #if/#endif pair too!