[webkit-reviews] review granted: [Bug 224800] REGRESSION (r275523): [iOS] Opaque system fill colors are incorrect in dark mode : [Attachment 426516] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Aditya Keerthi <akeerthi at apple.com>'s
request for review:
Bug 224800: REGRESSION (r275523): [iOS] Opaque system fill colors are incorrect
in dark mode
https://bugs.webkit.org/show_bug.cgi?id=224800

Attachment 426516: Patch

https://bugs.webkit.org/attachment.cgi?id=426516&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 426516
  --> https://bugs.webkit.org/attachment.cgi?id=426516
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426516&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:1343
> +	       if (useDarkAppearance)
> +		   return blendSourceOver(Color::black, systemColor);
> +	       else
> +		   return blendSourceOver(Color::white, systemColor);

This is one of those cases where ?: looks better:

    return blendSourceOver(useDarkAppearance ? Color::black : Color::white,
systemColor);