[webkit-reviews] review granted: [Bug 147073] Can't use Web Inspector on web views made by TestWebKitAPI : [Attachment 426472] Patch v1.1

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted BJ Burg <bburg at apple.com>'s
request for review:
Bug 147073: Can't use Web Inspector on web views made by TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=147073

Attachment 426472: Patch v1.1

https://bugs.webkit.org/attachment.cgi?id=426472&action=review




--- Comment #6 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 426472
  --> https://bugs.webkit.org/attachment.cgi?id=426472
Patch v1.1

View in context: https://bugs.webkit.org/attachment.cgi?id=426472&action=review

r=me

> Tools/ChangeLog:21
> +	   * TestWebKitAPI/PlatformUtilities.h: Add missing `#pragma once`.
> +	   * TestWebKitAPI/WTFStringUtilities.h: Force the build to fail
noisily if we have
> +	   attempted to redefine WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING. Force
the correct
> +	   ordering between "WTFStringUtilities.h" and
<wtf/text/StringConcatenate.h>.

NIT: would be preferable to have this be a separate patch

> Tools/TestWebKitAPI/DebugUtilities.h:41
> +	   if ([webView _isBeingInspected]) \

NIT: Should we add `#import "WKWebViewPrivate.h` to this file, or just
assume/hope that callers will have already done that?

> Tools/TestWebKitAPI/PlatformUtilities.h:26
> +#pragma once

NIT: Is it necessary/desirable to have both` #pragma once` and the `#ifndef`
pattern in the same file?