[webkit-reviews] review granted: [Bug 224782] -Warray-bounds warning in AirAllocateRegistersByGraphColoring.cpp with GCC 11 : [Attachment 426471] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 224782: -Warray-bounds warning in AirAllocateRegistersByGraphColoring.cpp
with GCC 11
https://bugs.webkit.org/show_bug.cgi?id=224782

Attachment 426471: Patch

https://bugs.webkit.org/attachment.cgi?id=426471&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 426471
  --> https://bugs.webkit.org/attachment.cgi?id=426471
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426471&action=review

> Source/JavaScriptCore/ChangeLog:8
> +	   These warnings don't make any sense to me. Suppress them.

If the warnings don’t make sense, we may need a comment at each of these two
sites.

> Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp:1546
> +IGNORE_WARNINGS_BEGIN("array-bounds")
>	       dataLog(m_code);
> +IGNORE_WARNINGS_END

How did you settle on using IGNORE_WARNINGS_BEGIN vs.
IGNORE_GCC_WARNINGS_BEGIN?