[webkit-reviews] review granted: [Bug 224654] Web Inspector: Graphics: add support for `steps()`/`spring()` CSS timing functions : [Attachment 426351] Patch

[bugzilla-daemon at webkit.org]

BJ Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 224654: Web Inspector: Graphics: add support for `steps()`/`spring()` CSS
timing functions
https://bugs.webkit.org/show_bug.cgi?id=224654

Attachment 426351: Patch

https://bugs.webkit.org/attachment.cgi?id=426351&action=review




--- Comment #4 from BJ Burg <bburg at apple.com> ---
Comment on attachment 426351
  --> https://bugs.webkit.org/attachment.cgi?id=426351
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426351&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/Geometry.js:600
> +	   if (!text?.length)

It would be helpful for future readers if there was a link to the section of
the spec where the grammar for this is defined.

> Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js:316
> +		       let stepX = width / easing.count; // always use the
defined number of steps to divide the duration

Nit: comment style seems off

> Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js:337
> +		       // FIXME: Is there a simpler way to do this?

I'd remove this.