[webkit-reviews] review requested: [Bug 224652] Web Inspector: Tree Outlines: `ondetach` can be called without `onattach` ever being called : [Attachment 426441] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 19 10:23:13 PDT 2021
Razvan Caliman <rcaliman at apple.com> has asked for review:
Bug 224652: Web Inspector: Tree Outlines: `ondetach` can be called without
`onattach` ever being called
https://bugs.webkit.org/show_bug.cgi?id=224652
Attachment 426441: Patch
https://bugs.webkit.org/attachment.cgi?id=426441&action=review
--- Comment #2 from Razvan Caliman <rcaliman at apple.com> ---
Created attachment 426441
--> https://bugs.webkit.org/attachment.cgi?id=426441&action=review
Patch
Hardened the checks guarding TreeElement.ondetach() and did some light manual
testing to check for side-effects. If you know of regressions or bugs happening
as a result of this, please let me know so I can check them.
More information about the webkit-reviews
mailing list