[webkit-reviews] review granted: [Bug 224758] Fix races in LibWebRTCCodecs introduced in r276214 : [Attachment 426433] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 19 09:42:54 PDT 2021

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 224758: Fix races in LibWebRTCCodecs introduced in r276214

Attachment 426433: Patch


--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 426433
  --> https://bugs.webkit.org/attachment.cgi?id=426433

View in context: https://bugs.webkit.org/attachment.cgi?id=426433&action=review

> Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:202
> +    if (m_connection) {

I would put that first since this is the fast path.

> Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:213
> +	      

Seems like we could use a Vector.

More information about the webkit-reviews mailing list