[webkit-reviews] review canceled: [Bug 224739] [WPE] Allow defining custom repo and branch for Cog checkout : [Attachment 426392] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 18 20:26:41 PDT 2021


Lauro Moura <lmoura at igalia.com> has canceled Lauro Moura <lmoura at igalia.com>'s
request for review:
Bug 224739: [WPE] Allow defining custom repo and branch for Cog checkout
https://bugs.webkit.org/show_bug.cgi?id=224739

Attachment 426392: Patch

https://bugs.webkit.org/attachment.cgi?id=426392&action=review




--- Comment #2 from Lauro Moura <lmoura at igalia.com> ---
Comment on attachment 426392
  --> https://bugs.webkit.org/attachment.cgi?id=426392
Patch

The check in "use_cog" is not enough. A leftover cog binary from a previous
build will lead to implying Cog is enabled.


More information about the webkit-reviews mailing list