[webkit-reviews] review granted: [Bug 224734] Selected image overlay text should never be visible : [Attachment 426384] Maybe slightly cleaner?

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 18 15:28:12 PDT 2021

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 224734: Selected image overlay text should never be visible

Attachment 426384: Maybe slightly cleaner?


--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 426384
  --> https://bugs.webkit.org/attachment.cgi?id=426384
Maybe slightly cleaner?

View in context: https://bugs.webkit.org/attachment.cgi?id=426384&action=review

> Source/WebCore/rendering/RenderElement.cpp:1533
> +    if (auto selectionStyle = getUncachedPseudoStyle({ PseudoId::Selection
> +	   return selectionStyle;

OK, does seem a little better. If worded clearly, a brief "why" comment here
might make it even better.

More information about the webkit-reviews mailing list