[webkit-reviews] review granted: [Bug 224729] [JSC] Use FixedVector for LLIntPrototypeLoadAdaptiveStructureWatchpoint vector : [Attachment 426374] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 224729: [JSC] Use FixedVector for
LLIntPrototypeLoadAdaptiveStructureWatchpoint vector
https://bugs.webkit.org/show_bug.cgi?id=224729

Attachment 426374: Patch

https://bugs.webkit.org/attachment.cgi?id=426374&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 426374
  --> https://bugs.webkit.org/attachment.cgi?id=426374
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426374&action=review

>
Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cp
p:48
> +    : Watchpoint(Watchpoint::Type::LLIntPrototypeLoadAdaptiveStructure)
> +    , m_owner(nullptr)
> +    , m_bytecodeOffset(0)

Can we initialize some or all of these in the class definition instead of in
the constructor? I guess not because of JSC_WATCHPOINT_FIELD.