[webkit-reviews] review granted: [Bug 224725] Use WebProcess::existingGPUProcessConnection() whenever possible : [Attachment 426360] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 224725: Use WebProcess::existingGPUProcessConnection() whenever possible
https://bugs.webkit.org/show_bug.cgi?id=224725

Attachment 426360: Patch

https://bugs.webkit.org/attachment.cgi?id=426360&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 426360
  --> https://bugs.webkit.org/attachment.cgi?id=426360
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426360&action=review

> Source/WebKit/WebProcess/GPU/media/RemoteAudioHardwareListener.cpp:58
> +    if (auto* gpuProcessConnection =
WebProcess::singleton().existingGPUProcessConnection()) {

I don’t think it’s an improvement to use the multi-word name for the local
variable. Yes, it’s the GPU Process connection, but the name can just be
connection in such tight if statements. You may not agree, but I really prefer
simple single-word names when possible, even if there is some slight ambiguity.