[webkit-reviews] review granted: [Bug 224702] [LayoutTests] Convert http/tests/blink convert PHP to Python : [Attachment 426291] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Apr 17 15:46:39 PDT 2021
Darin Adler <darin at apple.com> has granted Chris Gambrell
<cgambrell at apple.com>'s request for review:
Bug 224702: [LayoutTests] Convert http/tests/blink convert PHP to Python
https://bugs.webkit.org/show_bug.cgi?id=224702
Attachment 426291: Patch
https://bugs.webkit.org/attachment.cgi?id=426291&action=review
--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 426291
--> https://bugs.webkit.org/attachment.cgi?id=426291
Patch
As we start making changes to these it’s no longer great to keep them in a
directory named "blink". If they are redundant with WPT, then we could delete
these. If not, I wonder why we ended up getting tests from Blink, but no one
ever moved them into WPT.
Typically it’s good to have imported tests labeled as such so we don’t get
confused, but at this point it seems like "came from Blink" is increasingly a
historical note.
More information about the webkit-reviews
mailing list