[webkit-reviews] review granted: [Bug 224710] REGRESSION(r276164) [GTK] WKPreferencesDefaults API test is failing : [Attachment 426317] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Lauro Moura
<lmoura at igalia.com>'s request for review:
Bug 224710: REGRESSION(r276164) [GTK] WKPreferencesDefaults API test is failing
https://bugs.webkit.org/show_bug.cgi?id=224710

Attachment 426317: Patch

https://bugs.webkit.org/attachment.cgi?id=426317&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 426317
  --> https://bugs.webkit.org/attachment.cgi?id=426317
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426317&action=review

> Tools/TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:-77
> -   
EXPECT_FALSE(WKPreferencesGetOfflineWebApplicationCacheEnabled(preference));

Ah, yes.  I was wondering how I changed behavior, but I actually just changed
the expectations to match the Cocoa expectations.  This changes the
expectations back.
As mentioned in the original bug, you should probably have a discussion of
how/when you want to disable it.