[webkit-reviews] review granted: [Bug 224708] Deploy Ref/RefPtr in Editor : [Attachment 426308] Fixed release builds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 16 18:35:45 PDT 2021


Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 224708: Deploy Ref/RefPtr in Editor
https://bugs.webkit.org/show_bug.cgi?id=224708

Attachment 426308: Fixed release builds

https://bugs.webkit.org/attachment.cgi?id=426308&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 426308
  --> https://bugs.webkit.org/attachment.cgi?id=426308
Fixed release builds

View in context: https://bugs.webkit.org/attachment.cgi?id=426308&action=review

r=mews

> Source/WebCore/editing/Editor.cpp:3674
> +    if (auto startNode = makeRefPtr(range.startContainer());
startNode->hasEditableStyle())

Nit - I think this one can be `makeRef`.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:1196
> +    Editor& editor = frame->editor();

Nit - auto&?


More information about the webkit-reviews mailing list