[webkit-reviews] review denied: [Bug 224655] Web Inspector: add support for panning/zooming on images : [Attachment 426190] Patch

[bugzilla-daemon at webkit.org]

BJ Burg <bburg at apple.com> has denied Devin Rousso <drousso at apple.com>'s request
for review:
Bug 224655: Web Inspector: add support for panning/zooming on images
https://bugs.webkit.org/show_bug.cgi?id=224655

Attachment 426190: Patch

https://bugs.webkit.org/attachment.cgi?id=426190&action=review




--- Comment #4 from BJ Burg <bburg at apple.com> ---
Comment on attachment 426190
  --> https://bugs.webkit.org/attachment.cgi?id=426190
Patch

Overall I like the GestureController approach. Feedback on the feature itself:


1. Dragging only seems to work when clicking off the image. I kept trying to
drag the image itself around.

2. I quickly wish there was a sense of scale for the zoom. For example,
auto-showing rulers would be good.

3. For accessibility reasons, we should offer Zoom in button, Zoom out button,
and current scale. 

4. I highly prefer that we install a floating overlay in the upper right
(trailing) corner with zoom specific UI

5. I think the initial version needs scroll bars when the zoomed content
overflows the view container. This will help accessibility a bit.

6. Much lower down the list would be zoom related system keyboard shortcuts
like Cmd+, Cmd-, Cmd-0, Cmd-9, all as they are in Preview.app.

And lastly,

7. Images in the image collection content view should not have gesture
recognizer active and should not be able to zoom. It just gets really..
awkward. See screenshot.

I think #1, 5, and 7 should be addressed in the initial go, since they are more
bugs than not IMO.