[webkit-reviews] review granted: [Bug 224556] Exit the GPUProcess when under memory pressure if it is not being used : [Attachment 426230] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 16 10:03:42 PDT 2021


Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 224556: Exit the GPUProcess when under memory pressure if it is not being
used
https://bugs.webkit.org/show_bug.cgi?id=224556

Attachment 426230: Patch

https://bugs.webkit.org/attachment.cgi?id=426230&action=review




--- Comment #16 from Darin Adler <darin at apple.com> ---
Comment on attachment 426230
  --> https://bugs.webkit.org/attachment.cgi?id=426230
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426230&action=review

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:293
> +#if HAVE(AVASSETWRITERDELEGATE)

Would you be willing to consider just writing this out as:

    #if PLATFORM(COCOA) && ENABLE(MEDIA_STREAM) && HAVE(AVASSETWRITERDELEGATE)

instead of nesting it?


More information about the webkit-reviews mailing list