[webkit-reviews] review granted: [Bug 224670] Blend using calc() when necessary : [Attachment 426218] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 224670: Blend using calc() when necessary
https://bugs.webkit.org/show_bug.cgi?id=224670

Attachment 426218: Patch

https://bugs.webkit.org/attachment.cgi?id=426218&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 426218
  --> https://bugs.webkit.org/attachment.cgi?id=426218
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426218&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:851
> +	   if (!canInterpolate(from, to))
> +	       (destination->*m_setter)(progress ? LengthBox(value(to)) :
LengthBox(value(from)));
> +	   else {

You could early return instead of having an else branch.

> Source/WebCore/platform/LengthBox.h:61
> +    LengthBox(const LengthBox& box)
> +	   : RectEdges { Length(box.top()), Length(box.right()),
Length(box.bottom()), Length(box.left()) }
> +    {
> +    }
> +

I guess you also just give both RectEdges and LengthBox defaulted copy
constructors.