[webkit-reviews] review granted: [Bug 224659] Deploy Ref/RefPtr/WeakPtr in EditCommand and CompositeEditCommand : [Attachment 426197] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 16 02:44:03 PDT 2021


Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 224659: Deploy Ref/RefPtr/WeakPtr in EditCommand and CompositeEditCommand
https://bugs.webkit.org/show_bug.cgi?id=224659

Attachment 426197: Patch

https://bugs.webkit.org/attachment.cgi?id=426197&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 426197
  --> https://bugs.webkit.org/attachment.cgi?id=426197
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426197&action=review

> Source/WebCore/editing/CompositeEditCommand.cpp:1013
> +    ([&]() {

Are the parethesis necessary? I think just doing

[&] {
  ...
}();

works.


More information about the webkit-reviews mailing list