[webkit-reviews] review granted: [Bug 224632] Use kIOMainPortDefault where available : [Attachment 426166] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 15 18:04:06 PDT 2021
Alexey Proskuryakov <ap at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 224632: Use kIOMainPortDefault where available
https://bugs.webkit.org/show_bug.cgi?id=224632
Attachment 426166: Patch
https://bugs.webkit.org/attachment.cgi?id=426166&action=review
--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 426166
--> https://bugs.webkit.org/attachment.cgi?id=426166
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=426166&action=review
I would probably centralize this in one place if I were doing this, but seems
OK either way.
> Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_macos.mm:41
> #pragma clang diagnostic ignored "-Wdeprecated-declarations"
You can consider adding comments saying that the pragmas can be removed once
rdar://76706593 is fixed, but it's not terribly important.
More information about the webkit-reviews
mailing list