[webkit-reviews] review granted: [Bug 224440] Move RuntimeEnabledFeatures to Settings (Part 1) : [Attachment 425992] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 15 17:41:05 PDT 2021


Alex Christensen <achristensen at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 224440: Move RuntimeEnabledFeatures to Settings (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=224440

Attachment 425992: Patch

https://bugs.webkit.org/attachment.cgi?id=425992&action=review




--- Comment #10 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 425992
  --> https://bugs.webkit.org/attachment.cgi?id=425992
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425992&action=review

> Source/WTF/Scripts/Preferences/WebPreferences.yaml:1679
> +	 default: true

It feels like this might also need to be
WebCore::LibWebRTCProvider::webRTCAvailable but I'm not sure.  Getting this
wrong might affect the base system.


More information about the webkit-reviews mailing list