[webkit-reviews] review granted: [Bug 224518] Nullptr deref in CompositeEditCommand::isRemovableBlock in DeleteSelectionCommand::removeRedundantBlocks : [Attachment 426154] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Ian Gilbert <iang at apple.com>'s
request for review:
Bug 224518: Nullptr deref in CompositeEditCommand::isRemovableBlock in
DeleteSelectionCommand::removeRedundantBlocks
https://bugs.webkit.org/show_bug.cgi?id=224518

Attachment 426154: Patch

https://bugs.webkit.org/attachment.cgi?id=426154&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 426154
  --> https://bugs.webkit.org/attachment.cgi?id=426154
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426154&action=review

> Source/WebCore/ChangeLog:3
> +	   Editing null pointer dereference while resolving command

I've just renamed the bug. Please update the title here. It's overly generic.
Sorry I didn't notice earlier.

> LayoutTests/ChangeLog:3
> +	   Editing null pointer dereference while resolving command

Ditto.

> LayoutTests/ChangeLog:8
> +	   Add regression test.

Nit: Add *a* regression test.