[webkit-reviews] review granted: [Bug 224595] Add a mechanism to dump the PlatformCALayer subtree of a GraphicsLayer, for testing : [Attachment 426131] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 224595: Add a mechanism to dump the PlatformCALayer subtree of a
GraphicsLayer, for testing
https://bugs.webkit.org/show_bug.cgi?id=224595

Attachment 426131: Patch

https://bugs.webkit.org/attachment.cgi?id=426131&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 426131
  --> https://bugs.webkit.org/attachment.cgi?id=426131
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426131&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3967
> +	   ts << indent << "(bounds " << layer->bounds().width() << " " <<
layer->bounds().height() << ")\n";

size rather than bounds?

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3972
> +	   if (!flags.contains(PlatformLayerTreeAsTextFlags::IgnoreChildren)) {

Double negative is a bit hard to read. Maybe the flag should be
IncludeChildren?