[webkit-reviews] review granted: [Bug 224528] [LayoutTests] Convert http/tests/media convert PHP to Python : [Attachment 426073] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 15 08:56:33 PDT 2021

Jonathan Bedard <jbedard at apple.com> has granted Chris Gambrell
<cgambrell at apple.com>'s request for review:
Bug 224528: [LayoutTests] Convert http/tests/media convert PHP to Python

Attachment 426073: Patch


--- Comment #8 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 426073
  --> https://bugs.webkit.org/attachment.cgi?id=426073

View in context: https://bugs.webkit.org/attachment.cgi?id=426073&action=review

> LayoutTests/http/tests/media/resources/create-id3-db.php:26
> +    // $ LayoutTests/media/content/metadata.json

Actually, you should keep this as metadata.db, since this file is going to dump
PHP, not JSON.

More information about the webkit-reviews mailing list