[webkit-reviews] review granted: [Bug 224593] [JSC] Remove CodeBlock::RareData::m_catchProfiles : [Attachment 426078] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 224593: [JSC] Remove CodeBlock::RareData::m_catchProfiles
https://bugs.webkit.org/show_bug.cgi?id=224593

Attachment 426078: Patch

https://bugs.webkit.org/attachment.cgi?id=426078&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 426078
  --> https://bugs.webkit.org/attachment.cgi?id=426078
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426078&action=review

Nice work.  r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   So we should just iterate metadata for that and destroy them in the
destructor. Do not need to keep them separately.

/Do not need/No need/

> Source/JavaScriptCore/bytecode/ValueProfile.h:210
> +	   return
bitwise_cast<ValueProfileAndVirtualRegister*>(bitwise_cast<uint8_t*>(this) +
sizeof(ValueProfileAndVirtualRegisterBuffer));

Would the following work?  It's shorter:
    return bitwise_cast<ValueProfileAndVirtualRegister*>(this + 1);