[webkit-reviews] review granted: [Bug 224591] Deploy Ref/RefPtr in ReplaceSelectionCommand : [Attachment 426071] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 14 20:49:41 PDT 2021


Jiewen Tan <jiewen_tan at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 224591: Deploy Ref/RefPtr in ReplaceSelectionCommand
https://bugs.webkit.org/show_bug.cgi?id=224591

Attachment 426071: Patch

https://bugs.webkit.org/attachment.cgi?id=426071&action=review




--- Comment #2 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 426071
  --> https://bugs.webkit.org/attachment.cgi?id=426071
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426071&action=review

LGTM. r=me.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:562
> +	   ScriptDisallowedScope::InMainThread scriptDisallowedScope;

Why do we need this here?


More information about the webkit-reviews mailing list