[webkit-reviews] review granted: [Bug 224587] Crash in ReplaceSelectionCommand::mergeEndIfNeeded() : [Attachment 426069] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Julian Gonzalez
<julian_a_gonzalez at apple.com>'s request for review:
Bug 224587: Crash in ReplaceSelectionCommand::mergeEndIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=224587

Attachment 426069: Patch

https://bugs.webkit.org/attachment.cgi?id=426069&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 426069
  --> https://bugs.webkit.org/attachment.cgi?id=426069
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426069&action=review

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:984
> +    if (startOfInsertedContent.isNull() || endOfInsertedContent.isNull())

Can we add this assertion here?
ASSERT(startOfInsertedContent.isNull() == endOfInsertedContent.isNull());