[webkit-reviews] review granted: [Bug 224576] [macOS] Make image extraction interactions work for elements inside links : [Attachment 426044] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 224576: [macOS] Make image extraction interactions work for elements inside
links
https://bugs.webkit.org/show_bug.cgi?id=224576

Attachment 426044: Patch

https://bugs.webkit.org/attachment.cgi?id=426044&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 426044
  --> https://bugs.webkit.org/attachment.cgi?id=426044
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426044&action=review

r=me

> Source/WebCore/page/EventHandler.cpp:960
> +    VisibleSelection newSelection { oldSelection };

NIT: Do we have a preference as to style of this vs something like `auto
newSelection = oldSelection;`?

> Source/WebCore/page/EventHandler.cpp:1009
> +    auto isImageOverlayText = [&] (RefPtr<Node>&& node) {

NIT: Does this need to capture `&`?

NIT: It's a bit odd that this takes a `RefPtr<Node>&&` instead of just
`RefPtr<Node>&` or something ��