[webkit-reviews] review granted: [Bug 224496] Support Commit revision identifier in the Chart : [Attachment 425947] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Zhifei Fang <zhifei_fang at apple.com>'s request
for review:
Bug 224496: Support Commit revision identifier in the Chart
https://bugs.webkit.org/show_bug.cgi?id=224496

Attachment 425947: Patch

https://bugs.webkit.org/attachment.cgi?id=425947&action=review




--- Comment #8 from dewei_zhu at apple.com ---
Comment on attachment 425947
  --> https://bugs.webkit.org/attachment.cgi?id=425947
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425947&action=review

r=me

>
Websites/perf.webkit.org/browser-tests/customizable-test-group-form-tests.js:96
> +	   // click Radio button will enqueue to render, we will get a fresh
input element

Lower case R for `Radio`?

>
Websites/perf.webkit.org/browser-tests/customizable-test-group-form-tests.js:10
9
> +	   // customizableTestGroupForm will use
commitSet.updateRevisionForOwnerRepository to update the revision, need to
await this to see the input value get updated to 210948

need to await this to see the input value get updated to 210948 -> need to
await this to see the input value *gets* updated to 210948