[webkit-reviews] review granted: [Bug 224433] Refactor parameters to blending functions : [Attachment 425846] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 14 11:20:10 PDT 2021

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 224433: Refactor parameters to blending functions

Attachment 425846: Patch


--- Comment #11 from Dean Jackson <dino at apple.com> ---
Comment on attachment 425846
  --> https://bugs.webkit.org/attachment.cgi?id=425846

View in context: https://bugs.webkit.org/attachment.cgi?id=425846&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:77
> +    const CSSPropertyBlendingClient* client;
> +
> +    CSSPropertyBlendingContext(double progress, bool isDiscrete, const
CSSPropertyBlendingClient* client)

Don't people usually put the member variable after the constructor?

More information about the webkit-reviews mailing list