[webkit-reviews] review canceled: [Bug 222540] [Tools] Make run-buildbot-test compatible with buildbot 2.10.5 : [Attachment 425570] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 14 09:08:12 PDT 2021

Carlos Alberto Lopez Perez <clopez at igalia.com> has canceled Carlos Alberto
Lopez Perez <clopez at igalia.com>'s request for review:
Bug 222540: [Tools] Make run-buildbot-test compatible with buildbot 2.10.5

Attachment 425570: Patch


--- Comment #5 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 425570
  --> https://bugs.webkit.org/attachment.cgi?id=425570

View in context: https://bugs.webkit.org/attachment.cgi?id=425570&action=review

>> Tools/CISupport/ews-build/loadConfig.py:103
>> +	c['schedulers'].append(forceScheduler)
> This shouldn't be enabled in production EWS (atleast for now). Should be
under "if is_test_mode_enabled:"

mmm, right

>> Tools/CISupport/ews-build/steps.py:319
>> +		shell.ShellCommand.start(self)
> Is this part tested (locally)?

Yes. I assume wget is a command available on any developer machine.

>> Tools/CISupport/start-buildbot-server-virtualenv.py:166
>> +		    for worker in self._get_list_workers():
> Instead of creating ~100 workers on local machine, it's better to use create
just one worker named 'local-worker'. We already have support for
'local-worker' in EWS configuration and I am adding the support in
build.webkit.org in https://bugs.webkit.org/show_bug.cgi?id=224551.
local-worker attaches to all the builders. It is enabled automatically in test
mode (when the BUILDBOT_PRODUCTION env variable is not explicitly set). See

Interesting stuff. Will try to use it, thanks.

More information about the webkit-reviews mailing list