[webkit-reviews] review granted: [Bug 224435] [results.webkit.org] Document ref API argument : [Attachment 425907] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 224435: [results.webkit.org] Document ref API argument
https://bugs.webkit.org/show_bug.cgi?id=224435

Attachment 425907: Patch

https://bugs.webkit.org/attachment.cgi?id=425907&action=review




--- Comment #8 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 425907
  --> https://bugs.webkit.org/attachment.cgi?id=425907
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425907&action=review

>
Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/documentation.ht
ml:542
> +	       `Although ${localLink(['Query Parameters', 'UUID'], 'UUIDs')}
are the primary mechanism by which commits are identified in the results
database, many APIs allow callers to specify a more generic commit ref instead.
A commit ref is a string representation of a commit that will be converted to a
${localLink(['Query Parameters', 'UUID'], 'UUID')}. This ref will be different
depending on the underlying repository, but should be a commit revision,
identifier or hash. Some examples of commit refs in queires are:`,

Typo: queires

>
Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/documentation.ht
ml:546
> +	       `For both revision and identifier representations, it may be
necessary to specify a repository if your instance has multiple repositories,
because an identifier or revision may exist in both repositories.`,

"if your instance " => "if the results database instance"