[webkit-reviews] review granted: [Bug 223802] [Cocoa] Allow HTMLMediaElement preload > "metadata" on iPad by default : [Attachment 424368] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 223802: [Cocoa] Allow HTMLMediaElement preload > "metadata" on iPad by
default
https://bugs.webkit.org/show_bug.cgi?id=223802

Attachment 424368: Patch

https://bugs.webkit.org/attachment.cgi?id=424368&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 424368
  --> https://bugs.webkit.org/attachment.cgi?id=424368
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424368&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:199
>> +	_mediaDataLoadsAutomatically = !_allowsInlineMediaPlayback;
> 
> Not a problem of this patch. I am curious whether we can move this line out
of the macro.

Isn't this comparison backwards?