[webkit-reviews] review granted: [Bug 224513] Stop requiring a RemoteRenderingBackend for visibility propagation views : [Attachment 425922] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 224513: Stop requiring a RemoteRenderingBackend for visibility propagation
views
https://bugs.webkit.org/show_bug.cgi?id=224513

Attachment 425922: Patch

https://bugs.webkit.org/attachment.cgi?id=425922&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 425922
  --> https://bugs.webkit.org/attachment.cgi?id=425922
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425922&action=review

r=me

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:857
> +#if ENABLE(GPU_PROCESS)
> +    if (auto* gpuProcessConnection =
WebProcess::singleton().existingGPUProcessConnection())
> +	  
gpuProcessConnection->createVisibilityPropagationContextForPage(*this);
> +#endif // ENABLE(GPU_PROCESS)
> +#endif // HAVE(VISIBILITY_PROPAGATION_VIEW)

Feels slightly better to call gpuProcessConnectionDidBecomeAvailable() here
instead -- in case someone adds "things to do when I get a GPU Process" logic
in the future.