[webkit-reviews] review requested: [Bug 224511] Move cloneUBreakIterator declaration to IntlWorkaround.h : [Attachment 425915] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has asked  for review:
Bug 224511: Move cloneUBreakIterator declaration to IntlWorkaround.h
https://bugs.webkit.org/show_bug.cgi?id=224511

Attachment 425915: Patch

https://bugs.webkit.org/attachment.cgi?id=425915&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 425915
  --> https://bugs.webkit.org/attachment.cgi?id=425915
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425915&action=review

> Source/JavaScriptCore/runtime/IntlSegmenter.h:29
> +#include "IntlWorkaround.h"

This include should be added to the two .cpp files that use it, not to a
header.

Also, don’t forget to remove the declaration of cloneUBreakIterator from this
header.

> Source/JavaScriptCore/runtime/IntlWorkaround.h:28
> +#include <unicode/utypes.h>

It’s possible we could use a forward declaration for this too:

    typedef enum UErrorCode UErrorCode;

But not an important optimization, so never mind.