[webkit-reviews] review requested: [Bug 224389] Add support for a `media` attribute on `<meta name="theme-color" content="...">` : [Attachment 425913] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has asked  for review:
Bug 224389: Add support for a `media` attribute on `<meta name="theme-color"
content="...">`
https://bugs.webkit.org/show_bug.cgi?id=224389

Attachment 425913: Patch

https://bugs.webkit.org/attachment.cgi?id=425913&action=review




--- Comment #9 from Devin Rousso <drousso at apple.com> ---
Created attachment 425913

  --> https://bugs.webkit.org/attachment.cgi?id=425913&action=review

Patch

(In reply to Sam Weinig from comment #8)
> (In reply to Theresa O'Connor from comment #6)
> > (In reply to Theresa O'Connor from comment #5)
> > > (In reply to Sam Weinig from comment #3)
> > > 
> > > > It would be good to have a test for 'currentcolor', since the spec has
special rules for that
https://html.spec.whatwg.org/#parsed-as-a-css-color-value.
> > > 
> > > The spec PR for this doesn't depend on that algorithm:
https://github.com/whatwg/html/pull/6569/files
> > 
> > Whoops, sorry, the existing spec text *does* depend on that. The PR doesn't
change that.
> 
> The tests don't have to pass, I just think there should be tests.

Personally I'd rather add the test when adding the feature.  I've created a
followup <https://webkit.org/b/224509>.